WebGLRenderer: Fix setReversed() so reverseDepthBuffer: true works.#30809
Merged
Mugen87 merged 13 commits intomrdoob:devfrom Mar 27, 2025
Merged
WebGLRenderer: Fix setReversed() so reverseDepthBuffer: true works.#30809Mugen87 merged 13 commits intomrdoob:devfrom
setReversed() so reverseDepthBuffer: true works.#30809Mugen87 merged 13 commits intomrdoob:devfrom
Conversation
Contributor
Author
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Clean up title.
Mugen87
reviewed
Mar 27, 2025
Contributor
Author
Mugen87
approved these changes
Mar 27, 2025
WestLangley
reviewed
Mar 27, 2025
setReversed() so reverseDepthBuffer: true works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #30808
See #29579 (comment)
reverseDepthBuffer: truehas been broken since r170The problem is in WebGLState.setReversed(), code within the function assumes the value of the variable
reversedis set, but it is not set until the end of the functionAlso adds the example that @CodyJasonBennett wrote originally, closing #29765 and acting as a regression test