TSL: Fixes the return value of atomic* nodes#30971
Merged
sunag merged 2 commits intomrdoob:devfrom Apr 22, 2025
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
|
Thanks for this @sunag! |
This was referenced Apr 24, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* add `parents` properties * TSL: Fixes the return value of `atomic*` nodes
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* add `parents` properties * TSL: Fixes the return value of `atomic*` nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #30732 (comment)
Description
Detects whether
atomic*needs to return a value or can be added to the stack immediately, allowing it to be used inside or outside expressions.Summary