Frustum: Honor sprite offset in intersectsSprite().#31307
Merged
Mugen87 merged 2 commits intomrdoob:devfrom Jun 25, 2025
Merged
Frustum: Honor sprite offset in intersectsSprite().#31307Mugen87 merged 2 commits intomrdoob:devfrom
intersectsSprite().#31307Mugen87 merged 2 commits intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
WestLangley
reviewed
Jun 24, 2025
WestLangley
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #24822.
Description
I've run into #24822 when changing the center properties of sprites.
The PR fixes the issue by implementing the approach suggested by @WestLangley in #24828. So the idea is to increase the bounding sphere's radius by an offset derived from the sprite's center.
The implementation does not affect the intersection test for sprites with a default center value.
Below is a live example with the code from the original issue for reproducing the issue. The white quad prematurely disappears when moving it to the left.
https://jsfiddle.net/831pgxnv/