TSL: Add AA-samples parameter to reflector-node#31542
Merged
Mugen87 merged 2 commits intomrdoob:devfrom Aug 2, 2025
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Jul 31, 2025
Contributor
Author
|
Requires #31544 in order to avoid blank RT when specifying both MSAA and mipmaps. |
This was referenced Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default render-target for the reflector-node had no option to set anti-aliasing samples. For reflectors covering a large range, this can lead to unwanted flickering on distant and/or small objects, especially when using further processing on the reflector such as simulating roughness via blurring.
This PR adds a sample-parameter to the reflector to mitigate this.
As the constructor-signature of this node changed, the Typescript-definition package probably would need an update as well.