Skip to content

Material: Add missing map properties to toJSON().#31578

Merged
Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87:dev4
Aug 5, 2025
Merged

Material: Add missing map properties to toJSON().#31578
Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87:dev4

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 5, 2025

Fixed #31577.

Description

The PR adds the missing map properties sheenColorMap and sheenRoughnessMap to toJSON().

Since both properties are already supported in MaterialLoader, serialization/deserialization should work now as expected.

@Mugen87 Mugen87 added this to the r180 milestone Aug 5, 2025
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.63
79.03
338.63
79.03
+0 B
+0 B
WebGPU 567.29
156.89
567.29
156.89
+0 B
+0 B
WebGPU Nodes 565.9
156.64
565.9
156.64
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 470.05
113.73
470.27
113.76
+220 B
+29 B
WebGPU 638.76
172.87
638.98
172.93
+220 B
+61 B
WebGPU Nodes 593.4
162.16
593.63
162.2
+220 B
+42 B

@Mugen87 Mugen87 merged commit 4aa10f4 into mrdoob:dev Aug 5, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MeshPhysicalMaterial: sheenColorMap is not exported in .toJSON()

1 participant