Merged
Conversation
gkjohnson
approved these changes
Aug 14, 2025
Collaborator
gkjohnson
left a comment
gkjohnson
left a comment
There was a problem hiding this comment.
Looks good to me - it's been awhile since I wrote this demo but I believe the reason I'd added this was because I was seeing some discoloration of transparent pixels in downloaded images when using a transparent background with premultipliedAlpha === true but I'm no longer seeing that. So perhaps something changed in the project or browser or I may be misremembering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users should not be setting
premultipliedAlphatofalsein the renderer's constructor, unless they really know what they are doing.I assume this PR is OK, but @gkjohnson should confirm.