BatchedMesh: Fix index and attribute updates in the optimize method#32185
Merged
mrdoob merged 1 commit intomrdoob:devfrom Nov 6, 2025
Merged
BatchedMesh: Fix index and attribute updates in the optimize method#32185mrdoob merged 1 commit intomrdoob:devfrom
mrdoob merged 1 commit intomrdoob:devfrom
Conversation
… proper rendering
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds necessary update flags to the optimize() method in BatchedMesh to ensure geometry data changes are properly synchronized with the GPU. The changes address a bug where optimized geometry buffers were not being marked for update.
- Adds
needsUpdate = trueflags for index and attribute buffer updates during optimization - Sets
_visibilityChanged = trueto trigger re-rendering after geometry reorganization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gkjohnson
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix buffer sync issues in
BatchedMesh.prototype.optimize()that caused incorrect rendering after repacking. The method now:When
optimize()compacts geometry ranges, it mutates the underlying typed arrays viacopyWithin. However, without settingneedsUpdate = true, WebGL/WebGPU buffers aren’t re-uploaded, resulting in stale GPU data and visible artifacts, especially after sequences like add/delete/optimize.Also,
_visibilityChangedmust be set to ensure the next render pass rebuilds multi-draw ranges and respects updated starts/counts after repacking.