cleanup: remove redundant TODO comment in Vector3.js#32363
Merged
mrdoob merged 3 commits intomrdoob:devfrom Nov 25, 2025
Merged
cleanup: remove redundant TODO comment in Vector3.js#32363mrdoob merged 3 commits intomrdoob:devfrom
mrdoob merged 3 commits intomrdoob:devfrom
Conversation
The lengthSq() method is already correctly implemented and follows the project's naming convention. Removed the confusing TODO comment.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Owner
Sorry for confusing you! Hope you can move on with your day 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #32362
Description
This PR removes a redundant TODO comment in src/math/Vector3.js that was causing confusion. The comment
// TODO lengthSquared?appeared above the lengthSq() method, suggesting the method might need to be renamed or implemented differently.However, the lengthSq() method is already correctly implemented and follows the project's established naming convention of using the Sq suffix for methods that return squared values (similar to distanceToSquared(), manhattanDistanceTo(), etc.). The TODO comment was outdated and misleading, so it has been removed to improve code clarity.
Changes:
// TODO lengthSquared?comment from line 747 in src/math/Vector3.jsTesting:
npm run test-unit)npm run lint)