BloomNode: Implement disposal of materials to prevent memory leaks.#32452
Merged
Mugen87 merged 1 commit intomrdoob:devfrom Dec 2, 2025
Merged
BloomNode: Implement disposal of materials to prevent memory leaks.#32452Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87 merged 1 commit intomrdoob:devfrom
Conversation
querielo
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds proper disposal of materials in the BloomNode class to prevent memory leaks. The changes ensure that all dynamically created materials are properly cleaned up when the node is no longer needed.
- Added disposal of
_highPassFilterMaterialand_compositeMaterialwith null checks - Added disposal loop for all materials in the
_separableBlurMaterialsarray
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Mugen87
approved these changes
Dec 2, 2025
Mugen87
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is similar to #32395