SpriteSheetUVNode: Transform to TSL function and fix countNode access.#32693
Merged
Mugen87 merged 2 commits intomrdoob:devfrom Jan 9, 2026
Merged
Conversation
Collaborator
|
Some aditional taks:
|
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
6145446 to
631d5a8
Compare
Contributor
Author
@sunag Fixed! |
Mugen87
approved these changes
Jan 9, 2026
countNode access.
countNode access.countNode access.
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #32688
Description
This PR refactors
SpriteSheetUVNodefrom a class-based Node to a modern TSLFnfunction, as requested by the reviewer.Changes:
SpriteSheetUVNodeclass entirelyFnfunction implementation ofspritesheetUV()Fninstead ofnodeProxyand removed unusedNodeimportspritesheetUV()) is unchangedContribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=132382032