Examples: Remove obsolete shadow bias from WebGPU demos.#32715
Merged
Mugen87 merged 1 commit intomrdoob:devfrom Jan 11, 2026
Merged
Examples: Remove obsolete shadow bias from WebGPU demos.#32715Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87 merged 1 commit intomrdoob:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #32705
Description
Follow-up of #32705. With the latest shadow improvements, most of the existing
shadow.biasstatements can be removed.Some examples also configured shadow casting lights but without enabling shadows in the renderer. For clarity, I have removed these code blocks since they exist probably for testing purposes.
Some examples that needs a shadow bias (e.g. to mitigate self-shadow artifacts) have now a comment for explanation.