You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Slightly related: How do you feel about renaming NodeMaterialObserver to RenderObjectObserver and move it to src/renderers/common?
The concept is interesting, using RenderObjectObserver I would prefer to remove NodeMaterial.setupObserver() to avoid bringing dependencies from the renderers/common namespace into the NodeMaterial class and leave everything at the core. But I think that using NodeMaterialObserver with NodeMaterial.setupObserver() offers a higher level of extension, considering that the user could have their own MyMaterialObserver class for a specific material in order to optimize it. Unless we consider that there is no need to create extensions of the observer.. 🤔
I suggested the new name since NodeMaterialObserver checks a lot of properties and states which are unrelated to materials.RenderObjectObserver as a more generic name should better represent what this module actually does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #32535
Description
Rename
RenderPipelinetoRenderObjectPipeline.