Skip to content

ShadowFilterNode: Fix TSL warning in VSMShadowFilter.#32836

Merged
Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87:dev2
Jan 23, 2026
Merged

ShadowFilterNode: Fix TSL warning in VSMShadowFilter.#32836
Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87:dev2

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 23, 2026

Related issue: #32209 (comment)

Description

The PR fixes a TSL warning that has been introduces last release when optimize and refactoring VSM. It's this warning.

THREE.TSL: Return statement used in an inline 'Fn()'. Define a layout struct to allow return values.

In general, it's not supported to use JavaScript return statements inside If() TSL statements.

@Mugen87 Mugen87 added this to the r183 milestone Jan 23, 2026
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 357.49
84.84
357.49
84.84
+0 B
+0 B
WebGPU 622.14
172.83
622.16
172.83
+27 B
+1 B
WebGPU Nodes 620.74
172.59
620.77
172.59
+27 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 490.27
119.86
490.27
119.86
+0 B
+0 B
WebGPU 693.11
188.11
693.14
188.11
+27 B
+5 B
WebGPU Nodes 642.5
175.21
642.52
175.21
+27 B
+4 B

@Mugen87 Mugen87 merged commit c2b9e23 into mrdoob:dev Jan 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant