Skip to content

WebGPURenderer: Fix overrideMaterial node assignments.#32896

Merged
Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87:dev1
Jan 30, 2026
Merged

WebGPURenderer: Fix overrideMaterial node assignments.#32896
Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87:dev1

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 30, 2026

Fixed #32865.

Description

WebGPURenderer now better supports non-node materials as override materials by only accessing node properties if the override material is actually of type NodeMaterial. Otherwise null is used which is the expected default value of unused node properties.

@Mugen87 Mugen87 added this to the r183 milestone Jan 30, 2026
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 359.21
85.29
359.21
85.29
+0 B
+0 B
WebGPU 623.23
173.14
623.24
173.14
+15 B
+6 B
WebGPU Nodes 621.81
172.89
621.82
172.9
+15 B
+7 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 490.47
119.49
490.47
119.49
+0 B
+0 B
WebGPU 689.89
186.3
689.9
186.31
+15 B
+5 B
WebGPU Nodes 639.27
173.72
639.28
173.72
+15 B
+5 B

@Mugen87 Mugen87 merged commit f6185d1 into mrdoob:dev Jan 30, 2026
14 of 16 checks passed
@ycw
Copy link
Contributor

ycw commented Jan 30, 2026

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor: WebGPU renderer shows only one mesh normal in NORMALS shading mode

2 participants