Skip to content

TextureNode: Use compareNode for Android if compareStepNode is not compatible#32956

Merged
sunag merged 1 commit intomrdoob:devfrom
sunag:dev-fix-compareStepNode
Feb 4, 2026
Merged

TextureNode: Use compareNode for Android if compareStepNode is not compatible#32956
sunag merged 1 commit intomrdoob:devfrom
sunag:dev-fix-compareStepNode

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Feb 4, 2026

Related issue: #32548, #32953 (comment)

Description

compareStepNode was being used on Android even when it was incompatible. With this PR, compareStepNode will only be used if it is compatible with Texture.compareFunction.

@sunag sunag added this to the r183 milestone Feb 4, 2026
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 359.19
85.29
359.19
85.29
+0 B
+0 B
WebGPU 618.83
172.31
618.85
172.31
+18 B
+3 B
WebGPU Nodes 617.41
172.06
617.43
172.07
+18 B
+4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 490.85
119.65
490.85
119.65
+0 B
+0 B
WebGPU 692.64
187.41
692.66
187.41
+18 B
+8 B
WebGPU Nodes 641.9
174.8
641.92
174.81
+18 B
+6 B

@sunag sunag marked this pull request as ready for review February 4, 2026 18:19
@sunag sunag merged commit 4f40b0a into mrdoob:dev Feb 4, 2026
10 checks passed
@sunag sunag deleted the dev-fix-compareStepNode branch February 4, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant