Feat ldap ssl#140
Merged
mriedmann merged 2 commits intomriedmann:masterfrom Sep 22, 2020
r4nc0r:feat-ldap-ssl
Merged
Conversation
Owner
|
Perfect! Thank you very much. I will do a short review, I think we can add this soon. |
Contributor
Author
|
Could you add these two enviroment variables to the README? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added two enviroment variables for the issue #135:
HUMHUB_LDAP_CACERT: Here you can insert your certificate and it will be written into the file/etc/ssl/certs/cacert.crtand then added to/etc/openldap/ldap.confasTLS_CACERTexample in docker compose:
HUMHUB_LDAP_SKIP_VERIFY: if this is set to anything but 0 (zero is the standard value) it will writeTLS_REQCERT ALLOWto/etc/openldap/ldap.confI tested it locally and it works :)