Skip to content

Feat ldap ssl#140

Merged
mriedmann merged 2 commits intomriedmann:masterfrom
r4nc0r:feat-ldap-ssl
Sep 22, 2020
Merged

Feat ldap ssl#140
mriedmann merged 2 commits intomriedmann:masterfrom
r4nc0r:feat-ldap-ssl

Conversation

@r4nc0r
Copy link
Copy Markdown
Contributor

@r4nc0r r4nc0r commented Sep 22, 2020

Hi,

I added two enviroment variables for the issue #135:

  • HUMHUB_LDAP_CACERT : Here you can insert your certificate and it will be written into the file /etc/ssl/certs/cacert.crt and then added to /etc/openldap/ldap.conf as TLS_CACERT
    example in docker compose:
HUMHUB_LDAP_CACERT: |-
-----BEGIN CERTIFICATE-----
ahfoahofahofhlahfo...
-----END CERTIFICATE-----
  • HUMHUB_LDAP_SKIP_VERIFY: if this is set to anything but 0 (zero is the standard value) it will write TLS_REQCERT ALLOW to /etc/openldap/ldap.conf

I tested it locally and it works :)

@mriedmann
Copy link
Copy Markdown
Owner

mriedmann commented Sep 22, 2020

Perfect! Thank you very much. I will do a short review, I think we can add this soon.
EDIT: It is a very minimalistic change, I like it the way it is 👍 thx again

@mriedmann mriedmann merged commit 9fa677e into mriedmann:master Sep 22, 2020
@r4nc0r r4nc0r deleted the feat-ldap-ssl branch September 25, 2020 07:02
@r4nc0r
Copy link
Copy Markdown
Contributor Author

r4nc0r commented Sep 25, 2020

Could you add these two enviroment variables to the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants