run-many crashes when run with tui

[JelleBruisten]

Current Behavior

Running
nx run-many --target=i18n-extract
crashes ( see crash report below )

Running the same:
nx run-many --target=i18n-extract --no-tui
has no issues

Expected Behavior

The command should not crash

GitHub Repo

No response

Steps to Reproduce

1. execute nx run-many --target=something
2. crash

Nx Report

Node           : 22.14.0
OS             : win32-x64
Native Target  : x86_64-windows
yarn           : 4.9.4
daemon         : Disabled

nx (global)            : 22.0.2
nx                     : 22.5.3
@nx/js                 : 22.5.3
@nx/eslint             : 22.5.3
@nx/workspace          : 22.5.3
@nx/angular            : 22.5.3
@nx/jest               : 22.5.3
@nx/cypress            : 22.5.3
@nx/devkit             : 22.5.3
@nx/eslint-plugin      : 22.5.3
@nx/module-federation  : 22.5.3
@nx/node               : 22.5.3
@nx/plugin             : 22.5.3
@nx/rspack             : 22.5.3
@nx/vite               : 22.5.3
@nx/vitest             : 22.5.3
@nx/web                : 22.5.3
@nx/webpack            : 22.5.3
@nx/docker             : 22.5.3
typescript             : 5.9.3

---------------------------------------
Nx key licensed packages
Licensed to CtrlChain.

@nx/azure-cache            : 5.0.0
@nx/powerpack-azure-cache  : 5.0.0

---------------------------------------
Community plugins:
@alyle/ui                     : 19.0.0
@analogjs/vite-plugin-angular : 2.3.0
@analogjs/vitest-angular      : 2.3.0
@jsverse/transloco            : 8.2.1
@ngrx/component-store         : 21.0.1
@ngrx/eslint-plugin           : 21.0.1
@ngrx/operators               : 21.0.1
@ngrx/schematics              : 21.0.1
@ngrx/signals                 : 21.0.1
@nx/azure-cache               : 5.0.0
angular-eslint                : 21.2.0
---------------------------------------
Local workspace plugins:
@cca-tools/nx
---------------------------------------
Cache Usage: 0.00 B / 186.30 GB

Failure Logs

taskOutputChunks[taskId].push(output);
                                 ^

TypeError: Cannot read properties of undefined (reading 'push')
    at Object.lifeCycle.appendTaskOutput (D:\foo\node_modules\nx\src\tasks-runner\life-cycles\tui-summary-life-cycle.js:44:34)
    at CompositeLifeCycle.appendTaskOutput (D:\foo\node_modules\nx\src\tasks-runner\life-cycle.js:87:19)
    at CompositeLifeCycle.appendTaskOutput (D:\foo\node_modules\nx\src\tasks-runner\life-cycle.js:87:19)
    at D:\foo\node_modules\nx\src\tasks-runner\task-orchestrator.js:451:48
    at Socket.<anonymous> (D:\foo\node_modules\nx\src\tasks-runner\running-tasks\node-child-process.js:59:17)
    at Socket.emit (node:events:518:28)
    at addChunk (node:internal/streams/readable:561:12)
    at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
    at Socket.Readable.push (node:internal/streams/readable:392:5)
    at Pipe.onStreamRead (node:internal/stream_base_commons:189:23)

Package Manager Version

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

Workaround is to either edit tui-summary-life-cycle.js

  lifeCycle.appendTaskOutput = (taskId, output) => {
    taskOutputChunks[taskId]?.push(output);
  };

or run with --no-tui

[JelleBruisten]

Also note not every command seemed to have this issue, we identified 2 executors in our codebase that have this issue.

Looking at the tui-summary-life-cycle.ts

It looks like taskOutputChunks[taskId] is set to [] on startTasks,
outputs are pushed in this array in appendTaskOutput
and finally endTasks would delete it:

  if (terminalOutput !== undefined) {
    tasksToTerminalOutputs[task.id] = terminalOutput;
    delete taskOutputChunks[task.id];
  }

I wonder if its possible that endTasks runs before appendTaskOutput. Or that appendTaskOutput runs before startTasks. Causing this error to show up.

[wilfriedb]

We have the exact same issue with some of our tests. Also on Windows, same nx version.

[jeroenvheel]

We have the same issue:
NX Report

OS             : win32-x64
Native Target  : x86_64-windows
npm            : 11.11.0
daemon         : Disabled

nx (global)            : 22.5.4
nx                     : 22.5.4
@nx/js                 : 22.5.4
@nx/eslint             : 22.5.4
@nx/workspace          : 22.5.4
@nx/angular            : 22.5.4
@nx/jest               : 22.5.4
@nx/devkit             : 22.5.4
@nx/eslint-plugin      : 22.5.4
@nx/module-federation  : 22.5.4
@nx/playwright         : 22.5.4
@nx/rspack             : 22.5.4
@nx/web                : 22.5.4
@nx/webpack            : 22.5.4
typescript             : 5.9.3
---------------------------------------
Registered Plugins:
@nx/playwright/plugin
@nx/eslint/plugin
---------------------------------------
Community plugins:
@jsverse/transloco : 8.2.1
@ng-icons/core     : 33.1.0
angular-eslint     : 21.1.0
apollo-angular     : 13.0.0
ng-apexcharts      : 2.2.0


\node_modules\nx\src\tasks-runner\life-cycles\tui-summary-life-cycle.js:44
        taskOutputChunks[taskId].push(output);
                                 ^

TypeError: Cannot read properties of undefined (reading 'push')
    at lifeCycle.appendTaskOutput (\node_modules\nx\src\tasks-runner\life-cycles\tui-summary-life-cycle.js:44:34)
    at CompositeLifeCycle.appendTaskOutput (\node_modules\nx\src\tasks-runner\life-cycle.js:87:19)
    at CompositeLifeCycle.appendTaskOutput (\node_modules\nx\src\tasks-runner\life-cycle.js:87:19)
    at \node_modules\nx\src\tasks-runner\task-orchestrator.js:451:48
    at Socket.<anonymous> (\node_modules\nx\src\tasks-runner\running-tasks\node-child-process.js:67:17)
    at Socket.emit (node:events:519:28)
    at addChunk (node:internal/streams/readable:561:12)
    at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
    at Readable.push (node:internal/streams/readable:392:5)
    at Pipe.onStreamRead (node:internal/stream_base_commons:189:23)
49
Node.js v22.21.1