Skip to content

fix(angular-rspack): add fileReplacements to resolve.alias#34197

Merged
leosvelperez merged 2 commits intonrwl:masterfrom
faileon:fix/ng-rspack-file-replacements
Apr 14, 2026
Merged

fix(angular-rspack): add fileReplacements to resolve.alias#34197
leosvelperez merged 2 commits intonrwl:masterfrom
faileon:fix/ng-rspack-file-replacements

Conversation

@faileon
Copy link
Copy Markdown
Contributor

@faileon faileon commented Jan 23, 2026

Current Behavior

The fileReplacements option in @nx/angular-rspack is passed to the Angular AOT compiler but not added to rspack's resolve.alias configuration. This means file replacements only work during TypeScript compilation, not during module resolution/bundling.

Expected Behavior

File replacements should work consistently, replacing modules both during compilation and bundling - matching the behavior of @nx/rspack.

Related Issue(s)

#32647

@faileon faileon requested a review from a team as a code owner January 23, 2026 14:29
@faileon faileon requested a review from FrozenPandaz January 23, 2026 14:29
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 23, 2026

Deploy Preview for nx-docs canceled.

Name Link
🔨 Latest commit f14ca13
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69ddf93d657cd70008d90a39

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Jan 23, 2026 2:38pm

Request Review

@leosvelperez leosvelperez requested a review from a team as a code owner April 14, 2026 08:22
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 14, 2026

Deploy Preview for nx-dev canceled.

Name Link
🔨 Latest commit f14ca13
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69ddf93d6418a70008b6d990

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud bot commented Apr 14, 2026

View your CI Pipeline Execution ↗ for commit f14ca13

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 4m 8s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 7s View ↗
nx-cloud record -- pnpm nx conformance:check ✅ Succeeded 7s View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-14 08:31:18 UTC

Copy link
Copy Markdown
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leosvelperez leosvelperez merged commit b034987 into nrwl:master Apr 14, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants