FindConfigRoots: return error, not panic#1487
Merged
anderseknert merged 1 commit intoopen-policy-agent:mainfrom Apr 16, 2025
Merged
FindConfigRoots: return error, not panic#1487anderseknert merged 1 commit intoopen-policy-agent:mainfrom
anderseknert merged 1 commit intoopen-policy-agent:mainfrom
Conversation
srenatus
force-pushed
the
push-npqvkvzzqkmp
branch
from
d06fe7d to
d917a80
Compare
HookFirebolt
pushed a commit
to HookFirebolt/regal
that referenced
this pull request
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stumbled upon this when playing with the LSP and sending bad init parameters -- that caused
errto be non-nil, and ran into a nil deref oninfo.IsDir()💥Happy to add a test if you can point out a good spot 😄