Merged
Conversation
srenatus
approved these changes
May 5, 2025
Although with `only-scalars` set to `true`. I did review the violations reported without that, and while most didn't warrant "fixing", a a few did, and so I did. Also added an option to the rule to be able to list variable names that should be excluded. It's fun to play around, but the high-level goal here is mostly to have `regal lint bundle` run all rules, even if with some exceptions defined in the config. Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
prefer-value-in-head
branch
from
e654181 to
67acc57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although with
only-scalarsset totrue. I did review the violations reported without that, and while most didn't warrant "fixing", a a few did, and so I did.Also added an option to the rule to be able to list variable names that should be excluded.
It's fun to play around, but the high-level goal here is mostly to have
regal lint bundlerun all rules, even if with some exceptions defined in the config.