Various small fixes#1736
Merged
anderseknert merged 1 commit intoopen-policy-agent:mainfrom Oct 29, 2025
Merged
Conversation
Member
anderseknert
commented
Oct 29, 2025
anderseknert
commented
- Add debugging configuration to enable inlineValues in project
- Don't use hardcoded "/" in eval test paths (as that won't work on Windows)
- More efficient input creation in aggregate lint step
- Add debugging configuration to enable inlineValues in project - Don't use hardcoded "/" in eval test paths (as that won't work on Windows) - More efficient input creation in aggregate lint step Signed-off-by: Anders Eknert <anders@eknert.com>
anderseknert
force-pushed
the
small-fixes
branch
from
4c48230 to
ef339d5
Compare
charlieegan3
approved these changes
Oct 29, 2025
srenatus
approved these changes
Oct 29, 2025
| } | ||
| }, | ||
| // Enable to have values displayed inline during debugging | ||
| // The default value is "auto", which consults the language extension on whethher |
Contributor
There was a problem hiding this comment.
Suggested change
| // The default value is "auto", which consults the language extension on whethher | |
| // The default value is "auto", which consults the language extension on whether |
| } | ||
|
|
||
| createWithContent(t, tmpDir+"/workspace/foo/bar/input."+tc.fileExt, tc.fileContent) | ||
| inputPath := filepath.Join(workspacePath, "foo", "bar", "input."+tc.fileExt) |
Contributor
There was a problem hiding this comment.
filepath.Join is quite clever, I think you should be able to do this, too:
Suggested change
| inputPath := filepath.Join(workspacePath, "foo", "bar", "input."+tc.fileExt) | |
| inputPath := filepath.Join(workspacePath, "foo/bar/input."+tc.fileExt) |
Join also calls Clean, so it'll adjust your / and \ as needed, IIRC.
Comment on lines
+872
to
+878
| regal := ast.ObjectTerm( | ||
| ast.Item(ast.InternedTerm("operations"), ast.ArrayTerm(ast.InternedTerm("aggregate"))), | ||
| ast.Item(ast.InternedTerm("file"), ast.ObjectTerm( | ||
| ast.Item(ast.InternedTerm("name"), ast.InternedTerm("__aggregate_report__")), | ||
| ast.Item(ast.InternedTerm("lines"), ast.InternedEmptyArray), | ||
| )), | ||
| ) |
Contributor
There was a problem hiding this comment.
🤔 I wonder if the compiler will raise this out of the function body, since it's constant... alternatively, you could do that, if this is called more than once, perhaps in the LSP scenario.
Member
Author
There was a problem hiding this comment.
Yes, definitely for the LSP scenario! Will update 👍
Comment on lines
+441
to
449
| policies := make(map[string]string, 2) | ||
| policies["foo.rego"] = `package foo | ||
| import data.bar | ||
|
|
||
| default allow := false | ||
| ` | ||
| policies["bar.rego"] = `package bar | ||
| import data.foo.allow | ||
| ` |
Contributor
There was a problem hiding this comment.
Suggested change
| policies := map[string]string{ | |
| "foo.rego": `package foo | |
| import data.bar | |
| default allow := false | |
| `, | |
| "bar.rego": `package bar | |
| import data.foo.allow | |
| `, | |
| } |
Member
Author
|
@srenatus I'll come back to address your (all valid!) points later. Highest priority now is to just get as many of the windows tests to work before we prepare the next release, so I merged this so @charlieegan3 (who's also working on this) and I have a shared state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.