Added Rule: Disallow import rego.v1 by SeanLedford · Pull Request #1778 · open-policy-agent/regal

SeanLedford · 2025-11-18T23:29:29Z

Added an import rule to address the following issue!

Added necessary coverage as well. Would like to review e2e test changes before merging 😄

anderseknert

A solid start 👏 There doesn't seem to be any documentation included for this rule, but that should be a pretty quick fix given how it's pretty obvious what it does. Left a few comments, but this is an excellent start.

anderseknert · 2025-11-19T14:36:48Z

bundle/regal/rules/imports/disallow-rego-v1/disallow_rego_v1.rego

@@ -0,0 +1,31 @@
+# METADATA
+# description: Use `import rego.v1`


This should probably be "Use of disallowed import rego.v1"

anderseknert · 2025-11-19T14:37:26Z

bundle/regal/config/provided/data.yaml

    confusing-alias:
      level: error
+    disallow-rego-v1:
+      level: error


All good, but even if this pertains to imports, this rule should be in the custom category, where all optional rules are placed.

anderseknert · 2025-11-19T14:39:11Z

bundle/regal/rules/imports/disallow-rego-v1/disallow_rego_v1.rego

+notices contains result.notice(rego.metadata.chain()) if {
+	capabilities.is_opa_v1
+	input.regal.file.rego_version != "v0"
+}


I believe the notices can be removed for this rule, as enabling it manually assumes someone is running with a version of OPA at 1.0 or above.

anderseknert · 2025-11-19T14:39:33Z

bundle/regal/rules/imports/disallow-rego-v1/disallow_rego_v1.rego

+}
+
+report contains violation if {
+	capabilities.is_opa_v1


So this can go too.

anderseknert · 2025-11-19T14:40:54Z

e2e/cli_test.go

 		"file-length",
 		"rule-named-if",
 		"use-rego-v1",
+		"disallow-rego-v1",


The changes in this file are likely not needed once it's moved to the custom category.

anderseknert · 2025-11-19T14:43:41Z

Oh, I forgot! Once this rule is in the custom category — let's also enable it in our own linter configuration: https://github.com/open-policy-agent/regal/blob/main/.regal/config.yaml

No better way to test our rules than to use them ourselves :)

anderseknert

Awesome! Thanks a lot @SeanLedford 👏 Nothing blocking, but some comments to consider. Great work, and impressive how quickly you got here considering that not only is this a new code base for you, but one that involves a new language. Awesome!

Let me know when you have had a chance to read and consider my last comments.

(And btw, sorry for the delay in reviewing this. Had some non-work issues to deal on Friday :/ )

anderseknert · 2025-11-20T16:10:52Z

.regal/config.yaml

 rules:
  custom:
+    disallow-rego-v1:
+      level: error


anderseknert · 2025-11-23T22:57:31Z

bundle/regal/rules/custom/disallow-rego-v1/disallow_rego_v1_test.rego

+
+	foo if not bar
+	`)
+		with capabilities.is_opa_v1 as true


We no longer check the capabilities in the rule, so this can be removed. But no big deal 🙂

anderseknert · 2025-11-23T23:05:53Z

docs/rules/custom/disallow-rego-v1.md

+
+This rule is intended to be enabled for projects that have been configured to target versions of OPA from 1.0
+ onwards, but Regal does not explicitly check which version of OPA is being targeted for this rule. If working
+ with older versions of OPA and Rego, ensure that this rule is disabled.


ensure that this rule is disabled

Since this is the default, perhaps we can just say "you probably don't want to enable this rule".

(Unrelated to that, but what's up with the 1-space indentation on the 2 lines above? 😄)

anderseknert · 2025-11-23T23:06:13Z

docs/rules/custom/disallow-rego-v1.md

+
+## Related Resources
+
+- GitHub: [Source Code](https://github.com/open-policy-agent/regal/blob/main/bundle/regal/rules/custom/disallow-rego-v1/disallow_rego_v1.rego)


anderseknert · 2025-11-23T23:06:32Z

pkg/linter/linter_test.go


 	policy := `package p

-import rego.v1


anderseknert · 2025-11-23T23:07:07Z

bundle/regal/rules/custom/disallow-rego-v1/disallow_rego_v1_test.rego

+
+	foo if not bar
+	`)
+		with capabilities.is_opa_v1 as true


Signed-off-by: Sean Ledford <s_ledford@apple.com>

charlieegan3 · 2025-12-01T18:29:26Z

docs/rules/custom/disallow-rego-v1.md

@@ -0,0 +1,23 @@
+# disallow-rego-v1
+
+**Summary**: Disallow `import rego v1`


Suggested change

**Summary**: Disallow `import rego v1`

**Summary**: Use of disallowed `import rego v1`

I think the rules are generally named about what the use has done wrong, so it reads well when they see it in their editors, etc.

Signed-off-by: Sean Ledford <s_ledford@apple.com>

SeanLedford force-pushed the s_ledford/rule-disallow-import-rego-v1 branch from 774b0c1 to d7b4d58 Compare November 18, 2025 23:31

anderseknert reviewed Nov 19, 2025

View reviewed changes

SeanLedford force-pushed the s_ledford/rule-disallow-import-rego-v1 branch 3 times, most recently from 555367b to bbac31f Compare November 20, 2025 15:48

anderseknert approved these changes Nov 23, 2025

View reviewed changes

anderseknert linked an issue Nov 27, 2025 that may be closed by this pull request

Rule: Disallow import rego.v1 #1765

Closed

SeanLedford added 3 commits December 1, 2025 11:26

Rule: Disallow import rego.v1

cddf45f

Signed-off-by: Sean Ledford <s_ledford@apple.com>

Addressed PR feedback and updated test suite to accomodate changes

d14c4a1

Signed-off-by: Sean Ledford <s_ledford@apple.com>

Add docs for the new rule

f6ab4bf

Signed-off-by: Sean Ledford <s_ledford@apple.com>

SeanLedford force-pushed the s_ledford/rule-disallow-import-rego-v1 branch 2 times, most recently from 287448e to 24030da Compare December 1, 2025 18:05

charlieegan3 reviewed Dec 1, 2025

View reviewed changes

Documentation and Testing Tweaks from final PR feedback

bef5faf

Signed-off-by: Sean Ledford <s_ledford@apple.com>

SeanLedford force-pushed the s_ledford/rule-disallow-import-rego-v1 branch from 24030da to bef5faf Compare December 1, 2025 21:07

charlieegan3 merged commit 1b083ff into open-policy-agent:main Dec 2, 2025
8 checks passed

		@@ -0,0 +1,31 @@
		# METADATA
		# description: Use `import rego.v1`


		## Related Resources

		- GitHub: [Source Code](https://github.com/open-policy-agent/regal/blob/main/bundle/regal/rules/custom/disallow-rego-v1/disallow_rego_v1.rego)

		@@ -0,0 +1,23 @@
		# disallow-rego-v1

		Summary: Disallow `import rego v1`

	Summary: Disallow `import rego v1`
	Summary: Use of disallowed `import rego v1`

Conversation

SeanLedford commented Nov 18, 2025

Uh oh!

anderseknert left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anderseknert commented Nov 19, 2025

Uh oh!

anderseknert left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants