Fix false positive in prefer-equals-comparison#1828
Merged
charlieegan3 merged 1 commit intoopen-policy-agent:mainfrom Jan 13, 2026
Merged
Fix false positive in prefer-equals-comparison#1828charlieegan3 merged 1 commit intoopen-policy-agent:mainfrom
charlieegan3 merged 1 commit intoopen-policy-agent:mainfrom
Conversation
charlieegan3
approved these changes
Jan 13, 2026
charlieegan3
changed the title
We'd previously fail to account for comprehension term vars in this rule. I'm pretty sure the logic here needs to extend into other locations in Regal, but this at least fixes the immediate issue as reported. Fixes open-policy-agent#1826 Signed-off-by: Anders Eknert <anders.eknert@apple.com>
anderseknert
force-pushed
the
fix-prefer-equals-fp
branch
from
2ca40b4 to
0ba99d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd previously fail to account for comprehension term vars in this rule. I'm pretty sure the logic here needs to extend into other locations in Regal, but this at least fixes the immediate issue as reported.
Fixes #1826