fix(linter/vitest): Optimize hoisted_apis_on_top rule to only check first member#20068
Open
sidharthv96 wants to merge 1 commit intooxc-project:mainfrom
Open
fix(linter/vitest): Optimize hoisted_apis_on_top rule to only check first member#20068sidharthv96 wants to merge 1 commit intooxc-project:mainfrom
hoisted_apis_on_top rule to only check first member#20068sidharthv96 wants to merge 1 commit intooxc-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the vitest/hoisted_apis_on_top linter rule to avoid false positives by only treating a call as “hoisted” when the first member in the vi.* chain is a hoisted API (e.g., mock, hoisted, unmock), matching Vitest’s intended behavior.
Changes:
- Change hoisted-API detection from “any member in the chain” to “only the first member”.
- Add regression tests ensuring
vi.mocked(...).mock.calls...chains are not flagged.
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
vitest/hoisted_apis_on_topto check only if the first member is a hoisted api.This removes false positives like
vi.mocked(something).mock...being flagged as hoisted.Rule introduced in #17658