Merged
Conversation
oowekyala
commented
Jan 27, 2023
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/documentation/CommentSizeRule.java
Outdated
Show resolved
Hide resolved
oowekyala
commented
Jan 27, 2023
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/documentation/CommentSizeRule.java
Outdated
Show resolved
Hide resolved
f4b351b to
ba18f3b
Compare
Generated by 🚫 Danger |
Member
|
Great finding! Now that this is fixed however, it seems like a poor rule, specially regarding the "number of lines part"… at the very least I think Javadocs should be treated differently. I don't think there is any scenario were having "too much" javadoc is ever an issue, on the contrary, people usually complain for the lack of it… I suggest we add a new property |
4 tasks
8 tasks
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule: CommentSize
Describe the PR
*,//).Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)