TCA2 backport: enum scopes#3882
Open
stephencelis wants to merge 1 commit intotrait-deprecate-presentation-scopefrom
Open
TCA2 backport: enum scopes#3882stephencelis wants to merge 1 commit intotrait-deprecate-presentation-scopefrom
stephencelis wants to merge 1 commit intotrait-deprecate-presentation-scopefrom
Conversation
TCA2 is stricter about scoping along feature boundaries, which means composed scoping like `\.destination?.sheet` aren't desirable. But these APIs could be improved to begin with, and have in TCA2, so let's backport them to make the migration easier. ```swift // Before: $store.scope(state: \.$destination?.sheet, action: \.destination.sheet) // After: $store.scope(state: \.$destination, action: \.destination).sheet ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCA2 is stricter about scoping along feature boundaries, which means composed scoping like
\.destination?.sheetaren't desirable.But these APIs could be improved to begin with, and have in TCA2, so let's backport them to make the migration easier.