Move previews into root and include in gemspec#1404
Merged
Conversation
|
steves
force-pushed
the
steves-include-previews
branch
from
fab4452 to
a14299a
Compare
steves
force-pushed
the
steves-include-previews
branch
from
a14299a to
8e29027
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I paired on this with @joelhawksley. We've begun including Lookbook in
github/github. If we include our primer/view_components previews in the gem then we can pull them into the local Lookbook instance. After some debate we also decided to move them out oftestand into their own top level directory. It felt wrong including test files in the gem and previews really aren't tests. They can be used by tests but they are, themselves, not tests.