fix: deduplicate deploy inputs when using --build-cmd#381
Merged
coffee-cup merged 2 commits intomainfrom Dec 1, 2025
Merged
Conversation
When --build-cmd is passed, config step processing was adding a default
deploy output {"include": ["."]} even when the provider already added
one. This caused hasSignificantOverlap to return true, forcing llb.Copy
fallback instead of llb.Merge.
Add HasIncludeForStep helper to check if a path is already covered by
existing deploy inputs before adding duplicates.
coffee-cup
force-pushed
the
jr/fix-duplicate-deploy-inputs
branch
from
6a7fdb4 to
a36d81e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--build-cmdis passed, config step processing was adding a default deploy output{"include": ["."]}even when the provider already added one. This causedhasSignificantOverlapto return true, forcingllb.Copyfallback instead ofllb.Merge.HasIncludeForStephelper to check if a path is already covered by existing deploy inputs