Conversation
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: refactor: tabs visibility (#4302)OverviewThis PR refactors The core design is sound. The split into separate components to avoid calling inspector hooks when the inspector context is unavailable correctly follows React rules of hooks. Issues1. Tab visibility flash on initial load
This means on first render all four feature tabs are hidden, then pop in when 2. Never-resolving query function is fragile The default 3.
4. Trailing whitespace in className strings Two spots in 5. Ladle dev-tool styles added to shared The Observations (Non-blocking)
SummaryThe refactoring direction is good and the component hierarchy is clean. The main concern is a UX regression where tabs start hidden and flash in, caused by queries defaulting to "disabled" rather than "unknown." Addressing that — either by defaulting to visible while loading, or by tracking a loading state in |
995b259 to
d17d2a1
Compare
2e00b4d to
8057dda
Compare

Description
This change implements dynamic tab visibility for actor details based on feature availability. The actor tabs now conditionally show or hide based on whether specific features (workflow, database, state, queue) are enabled for the actor. When tabs are hidden, the system automatically selects the first available tab from a predefined priority order. The implementation also handles the case where actors are not running by showing all tabs but with appropriate guard content.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: