feat: migrate locking mocks from pegomock to uber-go/mock (Phase 1)

[jamengual]

Summary

• Migrate server/core/db and server/core/locking mock generation from pegomock to uber-go/mock (mockgen)
• Update all 15 consumer test files to coexist with both frameworks during the incremental migration
• Add go.uber.org/mock v0.6.0 as a direct dependency
• Add implementation plan (docs/IMPLEMENTATION_PLAN.md) tracking the 6-stage migration

This is Phase 1 of an incremental migration, replacing the abandoned big-bang approach from PR #5758. The coexistence pattern established here allows both pegomock and gomock to be used in the same test file — gomock for the migrated locking mocks, pegomock for remaining events/vcs mocks.

Key pattern changes

Aspect	Pegomock (before)	Gomock (after)
Constructor	NewMockLocker()	NewMockLocker(gomock.NewController(t))
Stubbing	When(mock.Method(Any[T]())).ThenReturn(v)	mock.EXPECT().Method(gomock.Any()).Return(v)
Verify once	mock.VerifyWasCalledOnce().Method()	mock.EXPECT().Method().Times(1) (before action)
Unstubbed calls	Returns zero values	Panics — requires .AnyTimes() for incidental calls

Files changed (20)

• 4 go:generate directives updated
• 4 mock files regenerated with mockgen
• 2 test files fully rewritten (pure gomock)
• 13 test files updated for coexistence
• 1 implementation plan added

Test plan

• go test ./server/core/locking/ -count=1 — all 23 locking tests pass
• go test ./server/events/ -count=1 — all events tests pass
• go test ./server/controllers/ -count=1 — all controller tests pass
• go test ./server/... -count=1 — full server test suite passes
• go mod tidy — clean module state
• CI pipeline passes

[dosubot]

Related Documentation

Checked 0 published document(s) in 1 knowledge base(s). No updates required.

^{How did I do? Any feedback?}  

[Copilot]

Pull request overview

This PR begins an incremental migration of Atlantis’ locking- and db-related mocks/tests from pegomock to go.uber.org/mock (gomock), enabling both frameworks to coexist in the same test files during the transition.

Changes:

• Updated server/core/db and server/core/locking go:generate directives to use mockgen, and regenerated the corresponding mock files.
• Converted/updated affected unit tests to use gomock for the migrated mocks while retaining pegomock for remaining mocks.
• Added go.uber.org/mock v0.6.0 to module dependencies and introduced an implementation plan doc.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
server/server_test.go	Uses gomock for locking mocks while keeping pegomock for template writer mocks.
server/server_internal_test.go	Converts db close tests from pegomock to gomock.
server/events/pull_closed_executor_test.go	Migrates locking locker usage to gomock within events tests.
server/events/project_locker_test.go	Rewrites project locker tests to gomock.
server/events/delete_lock_command_test.go	Uses gomock for locking locker while keeping pegomock for other mocks.
server/events/command_runner_test.go	Introduces gomock controllers for locking mocks and adds default “incidental call” expectations.
server/events/apply_command_runner_test.go	Updates apply-lock checks to gomock expectations.
server/core/locking/mocks/mock_locker.go	Regenerated Locker mock using MockGen.
server/core/locking/mocks/mock_apply_locker.go	Regenerated ApplyLocker mock using MockGen.
server/core/locking/mocks/mock_apply_lock_checker.go	Regenerated ApplyLockChecker mock using MockGen.
server/core/locking/locking_test.go	Migrated locking client tests from pegomock to gomock.
server/core/locking/locking.go	Switched Locker mock generation to mockgen.
server/core/locking/apply_locking.go	Switched ApplyLocker/ApplyLockChecker mock generation to mockgen.
server/core/db/mocks/mock_database.go	Regenerated Database mock using MockGen.
server/core/db/db.go	Switched Database mock generation to mockgen.
server/controllers/locks_controller_test.go	Uses gomock for locking mocks while keeping pegomock for remaining mocks.
server/controllers/api_controller_test.go	Uses gomock for Locker while keeping pegomock for remaining mocks.
go.mod	Adds go.uber.org/mock v0.6.0.
go.sum	Adds checksums for go.uber.org/mock v0.6.0.
docs/IMPLEMENTATION_PLAN.md	Adds a staged migration plan for the overall pegomock → gomock transition.

[jamengual]

Addressed the skipApplyLockCheckerSetup feedback — replaced the boolean flag with two TestConfig fields (applyLockCheckerReturn, applyLockCheckerErr) that let tests configure what the AnyTimes() catch-all returns.

Before: Conditional flag to skip setup + explicit EXPECT after setup
After: Always register AnyTimes() with TestConfig-provided return values — tests that care set the values, others get zero-value defaults

See commit b586582.

[nitrocode]

Is this file needed? If so, could it be named more specifically for the uber-go/mock adoption?

[jamengual]

I will remove it.

…

On Mon, Feb 23, 2026, 8:35 p.m. RB ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ On docs/IMPLEMENTATION_PLAN.md <#6253 (comment)> : Is this file needed? If so, could it be named more specifically for the uber-go/mock adoption? — Reply to this email directly, view it on GitHub <#6253 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ3ERA67SYE7D3DJEG3VZ34NPIIFAVCNFSM6AAAAACV4JERGGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNBUHE4TSNZTGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>