Remove some confusion in gap interface conversion method#39909
Merged
vbraun merged 15 commits intosagemath:developfrom Jan 6, 2026
Merged
Remove some confusion in gap interface conversion method#39909vbraun merged 15 commits intosagemath:developfrom
vbraun merged 15 commits intosagemath:developfrom
Conversation
1 task
|
Documentation preview for this PR (built with commit d6b3f14; changes) is ready! 🎉 |
fchapoton
reviewed
May 24, 2025
Contributor
Author
|
All tests passed. Not sure about gap/libgap separation correctness though. The task is made worse by some files such as |
user202729
changed the title
2 tasks
5 tasks
3 tasks
fchapoton
approved these changes
Jan 1, 2026
Contributor
fchapoton
left a comment
fchapoton
left a comment
There was a problem hiding this comment.
looks reasonable ; this will require further cleanup though
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 4, 2026
sagemathgh-39909: Remove some confusion in gap interface conversion method See the documentation changes in the issue below for an explanation why this change is correct. Basically `_gap_` must take in an interface object and return element of that object; while `_libgap_` must take no argument and return libgap element. Also make `IncidenceStructure` inherit from `SageObject` — as noted in the documentation of `SageObject`, all objects visible to the user ought to inherit from it. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39905 Not strictly necessary, but useful to see why this change is correct. URL: sagemath#39909 Reported by: user202729 Reviewer(s): Frédéric Chapoton, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 13, 2026
sagemathgh-41372: some details in Galois groups in particular, explicit use of `_libgap_` motivated by sagemath#39909 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41372 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 14, 2026
sagemathgh-41372: some details in Galois groups in particular, explicit use of `_libgap_` motivated by sagemath#39909 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41372 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the documentation changes in the issue below for an explanation why this change is correct. Basically
_gap_must take in an interface object and return element of that object; while_libgap_must take no argument and return libgap element.Also make
IncidenceStructureinherit fromSageObject— as noted in the documentation ofSageObject, all objects visible to the user ought to inherit from it.📝 Checklist
⌛ Dependencies
#39905
Not strictly necessary, but useful to see why this change is correct.