Allow passing elements to OperationTable not closed under operation#40108
Merged
vbraun merged 11 commits intosagemath:developfrom Dec 29, 2025
Merged
Allow passing elements to OperationTable not closed under operation#40108vbraun merged 11 commits intosagemath:developfrom
vbraun merged 11 commits intosagemath:developfrom
Conversation
Use the new parameter `closed` in OperationTable.__init__ with default value False to allow generating an operation table if the argument `elements` is passed and those elements are not necessarily closed under the operation.
kwankyu
reviewed
Sep 15, 2025
kwankyu
reviewed
Sep 15, 2025
kwankyu
reviewed
Sep 15, 2025
kwankyu
reviewed
Sep 15, 2025
kwankyu
reviewed
Sep 15, 2025
kwankyu
reviewed
Sep 15, 2025
kwankyu
reviewed
Sep 15, 2025
kwankyu
reviewed
Sep 15, 2025
kwankyu
reviewed
Sep 15, 2025
|
Documentation preview for this PR (built with commit d039d62; changes) is ready! 🎉 |
Contributor
Author
|
Hi @kwankyu, thank you for your comments! I updated the PR, could you please take a look at it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new parameter
closedinOperationTable.__init__to allow generating an operation table if the argumentelementsis passed and those elements are not necessarily closed under the operation.A motivating example of usage is to quickly check if the product of two 4-cycles can be a 3-cycle:
📝 Checklist
⌛ Dependencies