implement the lattices of sashes and pellytopes#40999
Merged
vbraun merged 13 commits intosagemath:developfrom Jan 6, 2026
Merged
implement the lattices of sashes and pellytopes#40999vbraun merged 13 commits intosagemath:developfrom
vbraun merged 13 commits intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit 4c9ba87; changes) is ready! 🎉 |
fchapoton
changed the title
Contributor
Author
tscrim
reviewed
Jan 1, 2026
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
It’s not clear to me why the pellytope implementations are in the sashes lattice file. The code for one doesn’t call the other (if I haven’t missed something).
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Contributor
Author
|
Thanks. I have added a little explanation. |
Collaborator
|
I still feel like the actual polytope construction would be better in the polytopes catalog as that is where such constructions naturally go and it makes it more discoverable. I'm not sure about the fans though. |
Contributor
Author
|
I have added the pellytopes to the catalog. |
tscrim
approved these changes
Jan 3, 2026
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
Okay, this is sufficient. Thanks.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 4, 2026
sagemathgh-40999: implement the lattices of sashes and pellytopes as simple examples of congruence-uniform lattice and closely related simple polytopes ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40999 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as simple examples of congruence-uniform lattice and closely related simple polytopes
📝 Checklist