Try to fix binomial CI failure, take 2#41075
Merged
vbraun merged 2 commits intosagemath:developfrom Dec 29, 2025
Merged
Conversation
2 tasks
user202729
force-pushed
the
expression-convert-to-bint
branch
2 times, most recently
from
1f33477 to
7f8ace3
Compare
|
Documentation preview for this PR (built with commit 7072a5a; changes) is ready! 🎉 |
Contributor
|
It seems this actually fix the bug. I do not see the error in |
Contributor
Author
|
It is likely better for Otherwise should be good. |
cxzhong
reviewed
Dec 25, 2025
| leading to arbitrary Python code being executed between the ``sig_on()`` | ||
| and the ``sig_off()``. | ||
| """ | ||
| sig_off() |
Contributor
There was a problem hiding this comment.
This seems we run twice sig_off()?
cxzhong
reviewed
Dec 25, 2025
| finally: | ||
| sig_off() | ||
| x = g_hold2_wrapper_sig(g_binomial, self._gobj, nexp._gobj, hold) | ||
| sig_off() |
Contributor
There was a problem hiding this comment.
In this line we already have sig_off
Contributor
Author
There was a problem hiding this comment.
intentional. Read the comment carefully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try to fix #40978 . I suppose the easiest way to test it is to set it as [CI fix] for a while to see if the issue still happens.
📝 Checklist
⌛ Dependencies