Use sig_block to avoid conflict signal handle#41209
Merged
vbraun merged 7 commits intosagemath:developfrom Feb 11, 2026
Merged
Conversation
Contributor
Author
|
@user202729 Can you help me review this. It is a minor improvement |
Contributor
|
add a test that would have failed without the change. |
|
Documentation preview for this PR (built with commit 82ad7ea; changes) is ready! 🎉 |
Contributor
Author
|
I will wait for #40980 merge |
Contributor
Author
|
@user202729 Please review this. Thank you. |
user202729
reviewed
Dec 25, 2025
| (1.418, 0.01) | ||
| (1.418, 0.01) | ||
|
|
||
| Ensure :issue:`30379` is fixed for monte_carlo_integral (c_monte_carlo_f):: |
Contributor
There was a problem hiding this comment.
Format function name as :func:`...`. Same for above.
Contributor
There was a problem hiding this comment.
And please mark the test as # long time since the CI is warning about it
Contributor
|
Otherwise, more or less correct. There's this case but probably not worth it to add a try/except. (if anything, I think the right behavior ought to be use a The |
orlitzky
reviewed
Dec 29, 2025
| Ensure :issue:`30379` is fixed for monte_carlo_integral (c_monte_carlo_f):: | ||
|
|
||
| sage: def f(x, y): return gamma_inc(2, 11/5) * x * y | ||
| sage: for algo in ['plain', 'miser', 'vegas']: # abs tol 0.1 |
Contributor
|
Looks good, thanks |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 5, 2026
sagemathgh-41209: Use sig_block to avoid conflict signal handle <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Improve sagemath#40980 , there are other two functions are also needs ``sig_block``. It is compatible with sagemath#40980 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> sagemath#40980 URL: sagemath#41209 Reported by: Chenxin Zhong Reviewer(s): Michael Orlitzky, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2026
sagemathgh-41209: Use sig_block to avoid conflict signal handle <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Improve sagemath#40980 , there are other two functions are also needs ``sig_block``. It is compatible with sagemath#40980 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> sagemath#40980 URL: sagemath#41209 Reported by: Chenxin Zhong Reviewer(s): Michael Orlitzky, user202729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve #40980 , there are other two functions are also needs
sig_block. It is compatible with #40980📝 Checklist
⌛ Dependencies
#40980