introduce the category of Bounded posets#41216
Merged
vbraun merged 4 commits intosagemath:developfrom Dec 21, 2025
Merged
Conversation
3 tasks
Contributor
Author
|
Would it be better to put "Bounded" lower in the list of axiom names ? EDIT: It seems not. |
tscrim
approved these changes
Nov 26, 2025
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
LGTM modulo one detail and one potential improvement.
Contributor
Author
|
Here is a way to make the "bounded finite" disappear. EDIT: namely I moved "Bounded" before "Finite" in the list of axioms. |
Contributor
Author
|
@tscrim : would you please have another look if you can ? |
tscrim
approved these changes
Dec 14, 2025
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
Thank you. Sorry for loosing track of this. LGTM.
Contributor
Author
|
Thanks a lot, Travis. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 20, 2025
sagemathgh-41216: introduce the category of Bounded posets as an useful thing to have also declare that finite lattices are bounded ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#41216 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as an useful thing to have
also declare that finite lattices are bounded
📝 Checklist