Fix logic error when computing rank deficient weak Popov forms with some options#41280
Merged
vbraun merged 2 commits intosagemath:developfrom Dec 21, 2025
Merged
Conversation
…bination of options include_zero_vectors=False and ordered=True
2 tasks
|
Documentation preview for this PR (built with commit 531f057; changes) is ready! 🎉 |
vincentmacri
suggested changes
Dec 10, 2025
Member
vincentmacri
left a comment
vincentmacri
left a comment
There was a problem hiding this comment.
Looks good! Thank you for the quick fix!
My only requested change is a small formatting fix, you can set this to positive review after making the change.
Co-authored-by: Vincent Macri <vincent.macri@ucalgary.ca>
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 20, 2025
sagemathgh-41280: Fix logic error when computing rank deficient weak Popov forms with some options Fixes sagemath#41278 This concerns univariate polynomial matrices and the main interface for weak Popov forms (`weak_popov_form`) which mostly handles options (the main computation is deferred to `_weak_popov_form` which is unchanged by this PR). In the rank deficient case, with some specific options (`include_zero_vectors=False` and `ordered=True`), the code contained some misplaced logic concerning zero rows that happened too late in the computations, leading to wrong results (see [sagemath#41278](sagemath#41278)). This PR fixes this issue, adds a test for it, and also makes some minor enhancements in code style. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#41280 Reported by: Vincent Neiger Reviewer(s): Vincent Macri, Vincent Neiger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41278
This concerns univariate polynomial matrices and the main interface for weak Popov forms (
weak_popov_form) which mostly handles options (the main computation is deferred to_weak_popov_formwhich is unchanged by this PR).In the rank deficient case, with some specific options (
include_zero_vectors=Falseandordered=True), the code contained some misplaced logic concerning zero rows that happened too late in the computations, leading to wrong results (see #41278).This PR fixes this issue, adds a test for it, and also makes some minor enhancements in code style.
📝 Checklist