some annotations and pep8 in generic_graph.py#41290
Merged
vbraun merged 2 commits intosagemath:developfrom Dec 21, 2025
Merged
Conversation
|
Documentation preview for this PR (built with commit 8d58d5b; changes) is ready! 🎉 |
dcoudert
approved these changes
Dec 13, 2025
Collaborator
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
LGTM.
The change in _layout_bounding_box makes the code much cleaner.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 20, 2025
sagemathgh-41290: some annotations and pep8 in generic_graph.py also a little change in the code at one point ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#41290 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also a little change in the code at one point
📝 Checklist