Skip to content

[docs] p-adic: Update docs to change printing-mode=digits to digits-unicode#41304

Merged
vbraun merged 4 commits intosagemath:developfrom
gulshan-123:docs/padic-digits-unicode
Dec 29, 2025
Merged

[docs] p-adic: Update docs to change printing-mode=digits to digits-unicode#41304
vbraun merged 4 commits intosagemath:developfrom
gulshan-123:docs/padic-digits-unicode

Conversation

@gulshan-123
Copy link
Copy Markdown
Contributor

@gulshan-123 gulshan-123 commented Dec 17, 2025

📝 Checklist

In #41276, I added the printing mode='digits-unicode' in p-adic printing.
This addition was to avoid ... being treated as wildcard in pydoctest module. digits-unicode replaced ... with unicode

This PR updates the doc to solve the problem.
I updated the docstring as well as the doctest to reflect the new change.

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729
Copy link
Copy Markdown
Contributor

you mean to link to #41276 instead of #41270 .

Comment thread src/sage/rings/padics/padic_printing.pyx
@gulshan-123 gulshan-123 marked this pull request as ready for review December 24, 2025 11:08
@gulshan-123
Copy link
Copy Markdown
Contributor Author

gulshan-123 commented Dec 24, 2025

Do we need to update docs in other files such as padics/factory.py, padics/relaxed_template.pxi, etc..

These are very long files, and will need more time to edit those. The current file will render here: doc-preview, which has a summary of all printing mode...

@github-actions
Copy link
Copy Markdown

Documentation preview for this PR (built with commit 9ac8127; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Copy Markdown
Contributor

If it is useful, there's a sage --fixdoctests tool that automatically fix the output for you. The input probably need manual editing though (or a search-and-replace)

Do we need to update docs in other files such as padics/factory.py, padics/relaxed_template.pxi, etc..

I'd say "strictly speaking not necessary", just that the new doctest is nice to have if someone want to avoid the test being too loose.

@vbraun vbraun merged commit 926e3f2 into sagemath:develop Dec 29, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants