Implement Polynomial_real_arb#41306
Merged
vbraun merged 5 commits intosagemath:developfrom Jan 6, 2026
Merged
Conversation
user202729
force-pushed
the
polynomial-real-arb
branch
3 times, most recently
from
14e1500 to
a4554a6
Compare
|
Documentation preview for this PR (built with commit f6d8d4e; changes) is ready! 🎉 |
user202729
force-pushed
the
polynomial-real-arb
branch
from
a4554a6 to
6bcab41
Compare
tscrim
approved these changes
Dec 31, 2025
Collaborator
tscrim
left a comment
tscrim
left a comment
There was a problem hiding this comment.
Feel free to change or ignore. Once decided (and possibly done), you can set a positive review.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 4, 2026
sagemathgh-41306: Implement Polynomial_real_arb Mostly copy-paste from `Polynomial_complex_arb` with `acb` replaced with `arb`. For ease of reviewing, the change is split into two commits, the first one is copy-paste (thus can be easily diffed against `Polynomial_complex_arb`), and the second one is the change on top of that. Results in a large speedup (especially for multiplication of polynomials with coefficients all having similar magnitudes, since flint use FFT when appropriate with $O(n \log n)$ algorithm, while Sage generic implementation mostly use schoolbook). The documentation doesn't show up on the website (HTML), but `polynomial_complex_arb` doesn't show up either, so this is mostly out of scope. To make it show up, one need appropriate `.rst` file in `src/doc/en/reference` (they were originally generated with sphinx- autodoc, I think) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41306 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly copy-paste from
Polynomial_complex_arbwithacbreplaced witharb.For ease of reviewing, the change is split into two commits, the first one is copy-paste (thus can be easily diffed against
Polynomial_complex_arb), and the second one is the change on top of that.Results in a large speedup (especially for multiplication of polynomials with coefficients all having similar magnitudes, since flint use FFT when appropriate with$O(n \log n)$ algorithm, while Sage generic implementation mostly use schoolbook).
The documentation doesn't show up on the website (HTML), but
polynomial_complex_arbdoesn't show up either, so this is mostly out of scope. To make it show up, one need appropriate.rstfile insrc/doc/en/reference(they were originally generated with sphinx-autodoc, I think)📝 Checklist
⌛ Dependencies