Merged
Conversation
|
Documentation preview for this PR (built with commit 2edc807; changes) is ready! 🎉 |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2026
sagemathgh-41422: Fix some formatting details - The regex that checks for tests block did not work properly in some of the cases below. (If you see the documentation changes, you'll see that the tests correctly disappear, **however** it was pointed out some time earlier that this is unintentional and the `TESTS::` ought to appear in developer's preview, just not in user-visible documentation.) - Some of the lines get indented by a number of spaces ≡ 1 (mod 4), which is inconsistent with the rest of the code base. - minor polish of some details in sagemath#41403. If you look at `__cinit__` of `Matrix_gf2e_dense` and its parent classes, you'll see that the additional arguments are not used. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> sagemath#41403 URL: sagemath#41422 Reported by: user202729 Reviewer(s): Frédéric Chapoton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TESTS::ought to appear in developer's preview, just not in user-visible documentation.)__cinit__ofMatrix_gf2e_denseand its parent classes, you'll see that the additional arguments are not used.📝 Checklist
⌛ Dependencies
#41403