Minor correct a typo in error msg of Integer.multifactorial#41440
Merged
vbraun merged 1 commit intosagemath:developfrom Jan 25, 2026
Merged
Minor correct a typo in error msg of Integer.multifactorial#41440vbraun merged 1 commit intosagemath:developfrom
Integer.multifactorial#41440vbraun merged 1 commit intosagemath:developfrom
Conversation
Contributor
|
Looks good to me! |
tscrim
approved these changes
Jan 14, 2026
|
Documentation preview for this PR (built with commit 0170031; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 17, 2026
sagemathgh-41440: Minor correct a typo in error msg of `Integer.multifactorial` ```python if k <= 0: raise ValueError("multifactorial only defined for nonpositive k") ``` `nonpositive` -> `positive` URL: sagemath#41440 Reported by: Majorana Oedipus Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 19, 2026
sagemathgh-41440: Minor correct a typo in error msg of `Integer.multifactorial` ```python if k <= 0: raise ValueError("multifactorial only defined for nonpositive k") ``` `nonpositive` -> `positive` URL: sagemath#41440 Reported by: Majorana Oedipus Reviewer(s): Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nonpositive->positive