Skip to content

pass TERM="dumb" to expect#41442

Merged
vbraun merged 1 commit intosagemath:developfrom
dimpase:patch-20
Jan 25, 2026
Merged

pass TERM="dumb" to expect#41442
vbraun merged 1 commit intosagemath:developfrom
dimpase:patch-20

Conversation

@dimpase
Copy link
Copy Markdown
Member

@dimpase dimpase commented Jan 14, 2026

a problem with pexpect interfaces on macOS and Python 3.14 surfaced in #41438

Apparently the problem is that on macOS libedit (via a newish Python readline module) uses the default fancy macOS term settings if it is not given by TERM envvar.

This fixes #41438

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 14, 2026

Documentation preview for this PR (built with commit 0d19716; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@vbraun
Copy link
Copy Markdown
Member

vbraun commented Jan 14, 2026

I vaguely remember seeing some program that didn't handle TERM=dumb, but hopefully that was fixed decades ago ;)

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 17, 2026
sagemathgh-41442: pass TERM="dumb" to expect
    
a problem with pexpect interfaces on macOS and Python 3.14 surfaced in
sagemath#41438

Apparently the problem is that on macOS libedit (via a newish Python
readline module) uses the default fancy macOS term settings if it is not
given by `TERM` envvar.

This fixes sagemath#41438

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#41442
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 19, 2026
sagemathgh-41442: pass TERM="dumb" to expect
    
a problem with pexpect interfaces on macOS and Python 3.14 surfaced in
sagemath#41438

Apparently the problem is that on macOS libedit (via a newish Python
readline module) uses the default fancy macOS term settings if it is not
given by `TERM` envvar.

This fixes sagemath#41438

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#41442
Reported by: Dima Pasechnik
Reviewer(s):
@vbraun vbraun merged commit c228e54 into sagemath:develop Jan 25, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pexpect broken on the latest macOS and Python 3.14

3 participants