Skip to content

remove deprecated operation between reals#41457

Merged
vbraun merged 1 commit intosagemath:developfrom
fchapoton:deprec_after_15114
Jan 25, 2026
Merged

remove deprecated operation between reals#41457
vbraun merged 1 commit intosagemath:developfrom
fchapoton:deprec_after_15114

Conversation

@fchapoton
Copy link
Copy Markdown
Contributor

after #15114 closed in 2021

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.

@github-actions
Copy link
Copy Markdown

Documentation preview for this PR (built with commit 0703954; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Copy Markdown
Collaborator

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not pointed all the places, but many elif and else statements in the code you have changed could be turned to if.

Comment thread src/sage/rings/real_mpfi.pyx
Comment thread src/sage/rings/real_mpfi.pyx
Comment thread src/sage/rings/real_mpfi.pyx
Comment thread src/sage/rings/real_mpfi.pyx
Comment thread src/sage/rings/real_mpfi.pyx
Comment thread src/sage/rings/real_mpfr.pyx
@fchapoton
Copy link
Copy Markdown
Contributor Author

yes, je sais. But je voulais minimiser les changements ici, parce que je soupçonne qu'il peut y avoir controverse..

@dcoudert
Copy link
Copy Markdown
Collaborator

ok, donc ce sera dans une autre PR.

Copy link
Copy Markdown
Collaborator

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 17, 2026
sagemathgh-41457: remove deprecated operation between reals
    
after sagemath#15114 closed in 2021

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
    
URL: sagemath#41457
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 19, 2026
sagemathgh-41457: remove deprecated operation between reals
    
after sagemath#15114 closed in 2021

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
    
URL: sagemath#41457
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit 165d8d7 into sagemath:develop Jan 25, 2026
24 of 26 checks passed
@fchapoton fchapoton deleted the deprec_after_15114 branch January 25, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants