add parameter immutable to (bi_|strongly_)connected_components_subgraphs#41493
Merged
vbraun merged 7 commits intosagemath:developfrom Feb 1, 2026
Merged
Conversation
|
Documentation preview for this PR (built with commit eeaee1c; changes) is ready! 🎉 |
Ordoviz
approved these changes
Jan 23, 2026
Collaborator
Author
|
Thanks for all the reviews ! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2026
sagemathgh-41493: add parameter immutable to `(bi_|strongly_)connected_components_subgraphs` This PR adds parameter immutable to methods `connected_components_subgraphs`, `biconnected_components_subgraphs` and `strongly_connected_components_subgraphs`. This way, we can choose whether the returned subgraphs should behave as the input graph (`None`) or be mutable (`False`) or immutable (`True`). This was discussed in sagemath#41488. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> sagemath#40965: add parameter `forbidden_vertices` to methods related to biconnected components URL: sagemath#41493 Reported by: David Coudert Reviewer(s): David Coudert, Lennard Hofmann, Martin Rubey
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parameter immutable to methods
connected_components_subgraphs,biconnected_components_subgraphsandstrongly_connected_components_subgraphs. This way, we can choose whether the returned subgraphs should behave as the input graph (None) or be mutable (False) or immutable (True).This was discussed in #41488.
📝 Checklist
⌛ Dependencies
#40965: add parameter
forbidden_verticesto methods related to biconnected components