add parameter immutable to graph generators in smallgraphs.py (part 1)#41501
Conversation
|
Documentation preview for this PR (built with commit 65d6b79; changes) is ready! 🎉 |
|
This new option is tested nowhere... is that intended? |
|
I added a few doctests. |
|
I can do the same for the other PRs. I did not do it by default as in most of the cases it's rather straightforward and file |
|
Thanks. For purpose of documentation I think it is fine to only have a bunch of them. However, for testing purposes it would be nice to have a test (via pytest?) of the form |
|
I keep this idea for a future PR, after the ongoing ones will be merged. There is still a lot of work to do for small graphs as some constructors depend on constructors from other modules that have not been touched yet (for instance to reduce potential conflicts). |
|
Sounds good to me! |
|
Thanks. |
sagemathgh-41501: add parameter immutable to graph generators in `smallgraphs.py` (part 1) Following discussions in sagemath#39177, we add the option to return immutable graphs to some generators in `src/sage/graphs/generators/smallgraphs.py`. - `HarborthGraph`, `Cell600`, `Cell120`, `SuzukiGraph`, `HallJankoGraph`, `BidiakisCube`, `BlanusaFirstSnarkGraph`, `BlanusaSecondSnarkGraph`, `BrinkmannGraph`, `BrouwerHaemersGraph`, `BuckyBall`, `GossetGraph`, `DoubleStarSnark` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41501 Reported by: David Coudert Reviewer(s):
sagemathgh-41706: add parameter immutable to graph generators in `smallgraphs.py` (part 13) Following discussions in sagemath#39177, and now that sagemath#41573, sagemath#41597 and sagemath#41599 have been merged, we add the option to return immutable graphs to the remaining generators in `src/sage/graphs/generators/smallgraphs.py`. - `DesarguesGraph`, `DurerGraph`, `MoebiusKantorGraph`, `NauruGraph`, `MathonStronglyRegularGraph` This concludes the work for `smallgraphs.py`. The next step will be to add in `pytest` a generic test on all graph generators (see sagemath#41501 (comment)). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41706 Reported by: David Coudert Reviewer(s): Martin Rubey
sagemathgh-41706: add parameter immutable to graph generators in `smallgraphs.py` (part 13) Following discussions in sagemath#39177, and now that sagemath#41573, sagemath#41597 and sagemath#41599 have been merged, we add the option to return immutable graphs to the remaining generators in `src/sage/graphs/generators/smallgraphs.py`. - `DesarguesGraph`, `DurerGraph`, `MoebiusKantorGraph`, `NauruGraph`, `MathonStronglyRegularGraph` This concludes the work for `smallgraphs.py`. The next step will be to add in `pytest` a generic test on all graph generators (see sagemath#41501 (comment)). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41706 Reported by: David Coudert Reviewer(s): Martin Rubey
sagemathgh-41706: add parameter immutable to graph generators in `smallgraphs.py` (part 13) Following discussions in sagemath#39177, and now that sagemath#41573, sagemath#41597 and sagemath#41599 have been merged, we add the option to return immutable graphs to the remaining generators in `src/sage/graphs/generators/smallgraphs.py`. - `DesarguesGraph`, `DurerGraph`, `MoebiusKantorGraph`, `NauruGraph`, `MathonStronglyRegularGraph` This concludes the work for `smallgraphs.py`. The next step will be to add in `pytest` a generic test on all graph generators (see sagemath#41501 (comment)). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41706 Reported by: David Coudert Reviewer(s): Martin Rubey
sagemathgh-41706: add parameter immutable to graph generators in `smallgraphs.py` (part 13) Following discussions in sagemath#39177, and now that sagemath#41573, sagemath#41597 and sagemath#41599 have been merged, we add the option to return immutable graphs to the remaining generators in `src/sage/graphs/generators/smallgraphs.py`. - `DesarguesGraph`, `DurerGraph`, `MoebiusKantorGraph`, `NauruGraph`, `MathonStronglyRegularGraph` This concludes the work for `smallgraphs.py`. The next step will be to add in `pytest` a generic test on all graph generators (see sagemath#41501 (comment)). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41706 Reported by: David Coudert Reviewer(s): Martin Rubey
sagemathgh-41706: add parameter immutable to graph generators in `smallgraphs.py` (part 13) Following discussions in sagemath#39177, and now that sagemath#41573, sagemath#41597 and sagemath#41599 have been merged, we add the option to return immutable graphs to the remaining generators in `src/sage/graphs/generators/smallgraphs.py`. - `DesarguesGraph`, `DurerGraph`, `MoebiusKantorGraph`, `NauruGraph`, `MathonStronglyRegularGraph` This concludes the work for `smallgraphs.py`. The next step will be to add in `pytest` a generic test on all graph generators (see sagemath#41501 (comment)). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41706 Reported by: David Coudert Reviewer(s): Martin Rubey
sagemathgh-41706: add parameter immutable to graph generators in `smallgraphs.py` (part 13) Following discussions in sagemath#39177, and now that sagemath#41573, sagemath#41597 and sagemath#41599 have been merged, we add the option to return immutable graphs to the remaining generators in `src/sage/graphs/generators/smallgraphs.py`. - `DesarguesGraph`, `DurerGraph`, `MoebiusKantorGraph`, `NauruGraph`, `MathonStronglyRegularGraph` This concludes the work for `smallgraphs.py`. The next step will be to add in `pytest` a generic test on all graph generators (see sagemath#41501 (comment)). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41706 Reported by: David Coudert Reviewer(s): Martin Rubey
Following discussions in #39177, we add the option to return immutable graphs to some generators in
src/sage/graphs/generators/smallgraphs.py.HarborthGraph,Cell600,Cell120,SuzukiGraph,HallJankoGraph,BidiakisCube,BlanusaFirstSnarkGraph,BlanusaSecondSnarkGraph,BrinkmannGraph,BrouwerHaemersGraph,BuckyBall,GossetGraph,DoubleStarSnark📝 Checklist
⌛ Dependencies