some cleanup in isogeny_small_degree.py#41519
Merged
vbraun merged 1 commit intosagemath:developfrom Feb 1, 2026
Merged
Conversation
yyyyx4
added
t: enhancement
p: minor / 4
c: elliptic curves
and removed
s: needs review
labels
yyyyx4
force-pushed
the
public/code_cleanup_in_isogeny_small_degree
branch
from
a923d3c to
c5860cb
Compare
|
Documentation preview for this PR (built with commit c5860cb; changes) is ready! 🎉 |
JohnCremona
approved these changes
Jan 26, 2026
Member
JohnCremona
left a comment
JohnCremona
left a comment
There was a problem hiding this comment.
I have read through all the changes and all look dood. Thanks!
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file was written a long time ago and both Python and Sage have received many improvements in the meantime. In this patch we modernize a lot of the code and restructure some of the functions a little bit to make them more readable. Everything should have remained the same in terms of functionality.
Cc: @JohnCremona