workaround for #38481: brute-force the kernel polynomial for bad characteristic-degree pairs#41565
Merged
vbraun merged 3 commits intosagemath:developfrom Feb 25, 2026
Merged
Conversation
|
Documentation preview for this PR (built with commit 45db70d; changes) is ready! 🎉 |
defeo
reviewed
Feb 17, 2026
…bad characteristic-degree pairs
yyyyx4
force-pushed
the
public/workaround_for_38481
branch
from
7481c3e to
45db70d
Compare
defeo
approved these changes
Feb 19, 2026
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 20, 2026
sagemathgh-41565: workaround for sagemath#38481: brute-force the kernel polynomial for bad characteristic-degree pairs The issue in sagemath#38481 has been long-standing and there's no immediate fix readily available; hence, in this patch we simply resort to a brute- force search in the cases that currently cause the code to just fail. This is (much?) slower than other approaches, but at least we get functionality to *work* that currently doesn't. URL: sagemath#41565 Reported by: Lorenz Panny Reviewer(s): Lorenz Panny, Luca De Feo
yyyyx4
added a commit
to yyyyx4/sage
that referenced
this pull request
Apr 12, 2026
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 14, 2026
sagemathgh-41968: remove local workaround for sagemath#38481 This workaround is now (sagemath#41565) done in a more central location. URL: sagemath#41968 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue in #38481 has been long-standing and there's no immediate fix readily available; hence, in this patch we simply resort to a brute-force search in the cases that currently cause the code to just fail.
This is (much?) slower than other approaches, but at least we get functionality to work that currently doesn't.