Fix tests with giac 2.0.0.19#41572
Merged
vbraun merged 2 commits intosagemath:developfrom Feb 25, 2026
Merged
Conversation
Member
Author
|
giac in sage-the-distro is 5 years old, it could use an update - but it involves a complex tarball generation step that I don't want to deal with @dimpase any chance you could help with this? |
|
Documentation preview for this PR (built with commit 15fa4f3; changes) is ready! 🎉 |
cxzhong
approved these changes
Feb 17, 2026
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 20, 2026
sagemathgh-41572: Fix tests with giac 2.0.0.19 giac tends to print random chatter to stderr, which occasionally breaks doctests. In 2.0.0.19, the approximate float value is printed when computing an exact integral. Guard tests against this by separating the computing from the answer display. We also update a test to account for `laplace(t^n, t, s)` now being correctly solved by giac. URL: sagemath#41572 Reported by: Antonio Rojas Reviewer(s): Chenxin Zhong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
giac tends to print random chatter to stderr, which occasionally breaks doctests. In 2.0.0.19, the approximate float value is printed when computing an exact integral. Guard tests against this by separating the computing from the answer display.
We also update a test to account for
laplace(t^n, t, s)now being correctly solved by giac.