get rid of old cruft half in class_function.py#41579
Merged
vbraun merged 2 commits intosagemath:developfrom Feb 11, 2026
Merged
get rid of old cruft half in class_function.py#41579vbraun merged 2 commits intosagemath:developfrom
vbraun merged 2 commits intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit 6dd472b; changes) is ready! 🎉 |
Collaborator
|
Should we also rename |
Contributor
Author
|
ok, done. |
Contributor
Author
|
and the CI seems to be green |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2026
sagemathgh-41579: get rid of old cruft half in class_function.py keeping only the libgap interface This is removing half of the modified file. Every method of the old class was checked to exist in the kept class. As another small step towards getting rid of pexpect interface to gap. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#41579 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keeping only the libgap interface
This is removing half of the modified file. Every method of the old class was checked to exist in the kept class.
As another small step towards getting rid of pexpect interface to gap.
📝 Checklist